Use res.status()

[kingcody]

As pointed out by @eikaramba, Express 4 now uses a syntax such as:

res.status(200).send('My Page');
res.status(201).json({token: token});

This should be implemented in the server code and endpoint template.

[gintsgints]

I would like to make necesary changes. Sadly I cannot make fork on github. It always make me to generator-angular fork. So I start with local clone.

[JaKXz]

Whoops misclicks. Looking forward to the PR @gintsgints 😄

[gintsgints]

Can you please point me on instructions how to make PR from local clone?
Or somehow I can fix issue on creating wrong fork.

[kingcody]

@gintsgints you'll need to have a fork on github to be able to push new beaches to. Once a new branch is pushed to github you'll see a button on your project's main page to create a PR.

We'll need to get you a proper fork before you can make a PR.

I'm guessing you've tried clicking the fork button on the main page for this project?

[JaKXz]

I believe you can still make PRs with a local clone. Just push to your topic branch as usual (e.g. origin/fix-res-status) and then you'll have to manually do the compare in GitHub:

https://github.com/gintsgints/generator-angular-fullstack/compare/DaftMonk:master...fix-res-status

Or, you could give git-extras a shot, see if the git fork command works. It's a great library. 😄

[kingcody]

Perhaps I'm missing something but if @gintsgints simply cloned this repo then his origin would be this repo by default. He would need to create a new project on github and then add it as a remote. Then he could push to it and maybe(?) make a PR.

[JaKXz]

@kingcody yup, sorry I left out the [implicit] steps of replacing the origin remote.

[gintsgints]

This way, I managed to create repository at github that is actual clone of generator-angular-fullstack. But it now do not want to allow to create PR from two "different" repos :(

[kingcody]

@gintsgints I've made a branch containing the changes for this issue. I was wondering if you would like to review it or possibly submit your own PR. Either way thanks for all your help on the project :)

[gintsgints]

First difference I found is I use:

return res.status(204);

yours

return res.status(204).end();

I do not know is end() needed or not but it worked for me without.

[gintsgints]

Also do not know what could be better:

res.json(users);

vs

res.status(200).json(users);

probably first :)

[kingcody]

@gintsgints as for .end() see here (:

[gintsgints]

@kingcody agreed on .end() 👍

[kingcody]

Thanks @gintsgints, I appreciate the extra set of eyes on this.

[gintsgints]

What else... I had different files for modification. (IMHO I have modified master).

[gintsgints]

Mean yours and mine templates name.controller.js was different.
Mine had fragment like this:

<%= classedName %>.findById(req.params.id, function (err, <%= name %>) {
     if (err) { return handleError(res, err); }
-    if(!<%= name %>) { return res.send(404); }
+    if(!<%= name %>) { return res.state(404); }
     var updated = _.merge(<%= name %>, req.body);
     updated.save(function (err) {
       if (err) { return handleError(res, err); }
-      return res.json(200, <%= name %>);
+      return res.state(200).json(<%= name %>);

[kingcody]

I did have a typo in name.controller.js it should be fixed in the most recent push.

[JaKXz]

I think this was taken care of in #704, correct me if I'm wrong.

[gintsgints]

Yes. All done.
2014. gada 6. dec. 20:12, "Jason Kurian" [email protected]
rakstīja:

I think this was taken care of in #704
#704,
correct me if I'm wrong.

—
Reply to this email directly or view it on GitHub
#576 (comment)
.