chore(app): update express res code

Changes:
- use `res.status()` instead of `res.verb(123, item)`

Closes angular-fullstack#576

Author: kingcody

Diff for: app/templates/server/api/thing/thing.controller.js

@@ -15,23 +15,23 @@ var Thing = require('./thing.model');
 function handleError(res, statusCode){
   statusCode = statusCode || 500;
   return function(err){
-    res.send(statusCode, err);
+    res.status(statusCode).send(err);
   };
 }
 
 function responseWithResult(res, statusCode){
   statusCode = statusCode || 200;
   return function(entity){
     if(entity){
-      return res.json(statusCode, entity);
+      return res.status(statusCode).json(entity);
     }
   };
 }
 
 function handleEntityNotFound(res){
   return function(entity){
     if(!entity){
-      res.send(404);
+      res.status(404).end();
       return null;
     }
     return entity;
@@ -53,7 +53,7 @@ function removeEntity(res){
     if(entity){
       return entity.removeAsync()
         .then(function() {
-          return res.send(204);
+          return res.status(204).end();
         });
     }
   };

Diff for: app/templates/server/api/user(auth)/user.controller.js

@@ -8,21 +8,21 @@ var jwt = require('jsonwebtoken');
 var validationError = function(res, statusCode) {
   statusCode = statusCode || 422;
   return function(err){
-    res.json(statusCode, err);
+    res.status(statusCode).json(err);
   };
 };
 
 function handleError(res, statusCode){
   statusCode = statusCode || 500;
   return function(err){
-    res.send(statusCode, err);
+    res.status(statusCode).send(err);
   };
 }
 
 function respondWith(res, statusCode){
   statusCode = statusCode || 200;
   return function(){
-    res.send(statusCode);
+    res.status(statusCode).end();
   };
 }
 
@@ -33,7 +33,7 @@ function respondWith(res, statusCode){
 exports.index = function(req, res) {
   User.findAsync({}, '-salt -hashedPassword')
     .then(function (users) {
-      res.json(200, users);
+      res.json(users);
     })
     .catch(handleError(res));
 };
@@ -62,7 +62,7 @@ exports.show = function (req, res, next) {
   User.findByIdAsync(userId)
     .then(function (user) {
       if(!user) {
-        return res.send(401);
+        return res.status(401).end();
       }
       res.json(user.profile);
     })
@@ -97,7 +97,7 @@ exports.changePassword = function(req, res, next) {
           .spread(respondWith(res, 200))
           .catch(validationError(res));
       } else {
-        return res.send(403);
+        return res.status(403).end();
       }
     });
 };
@@ -110,7 +110,7 @@ exports.me = function(req, res, next) {
 
   User.findOneAsync({ _id: userId }, '-salt -hashedPassword')
     .then(function(user) { // don't ever give out the password or salt
-      if (!user) { return res.json(401); }
+      if (!user) { return res.status(401).end(); }
       res.json(user);
     })
     .catch(function(err){ return next(err); });

Diff for: app/templates/server/auth(auth)/auth.service.js

@@ -28,7 +28,7 @@ function isAuthenticated() {
       User.findByIdAsync(req.user._id)
         .then(function (user) {
           if (!user) {
-            return res.send(401);
+            return res.status(401).end();
           }
           req.user = user;
           next();
@@ -54,7 +54,7 @@ function hasRole(roleRequired) {
         next();
       }
       else {
-        res.send(403);
+        res.status(403).end();
       }
     });
 }
@@ -71,7 +71,7 @@ function signToken(id) {
  */
 function setTokenCookie(req, res) {
   if (!req.user) {
-    return res.json(404, { message: 'Something went wrong, please try again.'});
+    return res.status(404).json({ message: 'Something went wrong, please try again.'});
   }
   var token = signToken(req.user._id, req.user.role);
   res.cookie('token', JSON.stringify(token));

Diff for: app/templates/server/auth(auth)/local/index.js

@@ -9,12 +9,12 @@ var router = express.Router();
 router.post('/', function(req, res, next) {
   passport.authenticate('local', function (err, user, info) {
     var error = err || info;
-    if (error) return res.json(401, error);
-    if (!user) return res.json(404, {message: 'Something went wrong, please try again.'});
+    if (error) return res.status(401).json(error);
+    if (!user) return res.status(404).json({message: 'Something went wrong, please try again.'});
 
     var token = auth.signToken(user._id, user.role);
     res.json({token: token});
   })(req, res, next)
 });
 
-module.exports = router;
+module.exports = router;

Diff for: app/templates/server/components/errors/index.js

@@ -11,8 +11,7 @@ module.exports[404] = function pageNotFound(req, res) {
     status: statusCode
   };
 
-  res.status(result.status);
-  res.render(viewFilePath, function (err) {
+  res.status(result.status).render(viewFilePath, function (err) {
     if (err) { return res.json(result, result.status); }
 
     res.render(viewFilePath);

Diff for: endpoint/templates/name.controller.js

@@ -6,23 +6,23 @@ var <%= classedName %> = require('./<%= name %>.model');
 function handleError(res, statusCode){
   statusCode = statusCode || 500;
   return function(err){
-    res.send(statusCode, err);
+    res.status(statusCode).send(err);
   };
 }
 
 function responseWithResult(res, statusCode){
   statusCode = statusCode || 200;
   return function(entity){
     if(entity){
-      return res.json(statusCode, entity);
+      return res.status(statusCode).json(entity);
     }
   };
 }
 
 function handleEntityNotFound(res){
   return function(entity){
     if(!entity){
-      res.send(404);
+      res.status(404).end();
       return null;
     }
     return entity;
@@ -44,7 +44,7 @@ function removeEntity(res){
     if(entity){
       return entity.removeAsync()
         .then(function() {
-          return res.send(204);
+          return res.status(204).end();
         });
     }
   };