-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for sequelize #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That would be really awesome. For complex DB structures and JOIN queries Mongo is certainly not the best choice. Thank you for your great project. |
Can't wait! |
I know it is a bad question, but do you have an idea of the release timeframe for 2.1.0? Unfortunately now I can just offer my best effort to test the Sequelize integration. |
Cleverstack already uses Sequelize. And if everyone worked together there'd be no need to make trade-offs . Please take a minute to do this survey. |
it should be not either Sequelize or mongodb but option to add both if needed , i am using Sequelize for analytics & mongo for app data. |
+1 on this |
Is this being currently worked on? If not, I'm thinking of submitting a PR for this in 1~2 weeks or so, would that be cool? First question first: should we go with Sequelize 1.x or 2.x for this? I'm thinking 1.x (stable), which is what I've been using in projects, but maybe you folks know more than I do and have a really strong argument for going 2.x? I really don't know... Next, I'm thinking the UX for this should be something along the lines of what @programming-kid describes, but let me flesh it out a bit:
Do the above make any sense? Let me know, & thanks all contributors for the great job on this generator. |
i agree with all points proposed by @sigriston , it llooks good |
+1 |
+1 i just converted a sample project to sequelize+postgres, feel free to take a look at https://github.com/dotch/angular-fullstack-sequelize-demo |
@dotch Yeah I started working on this about a week ago. I should have something to PR sometime next week or so. Thanks for the help with the converted project, that's more or less where I'm at right now; currently working on ensuring 100% E2E test passes! About the models thing, I'm going the way of keeping the model files in the API endpoint folder and then just having a main module (residing in the |
Very good news! |
Hi @sigriston, any update on this issue? Did you share your current code status somewhere? |
@Toub whew, I think I'm done. Check out the |
this is a MEAN stack (Mongo)...is there any reason we should be support SQL? |
@chovy the most salient point I get from this is that more people are familiar with sql databases which lowers the barrier to adoption. Also, I think another strong case for SQL databases is that they can support complicated multi-record, multi-table atomic transactions, but Mongo databases can't. |
@chovy this is a very versatile angular-fullstack generator, not specifically only MEAN-Stack. |
PR was merged; this should be closed, ya? |
@DaftMonk, since this has been merged now, is there any chance it can be published to npm without having to wait for all the other things in milestone 2.1.0? What if some of the remaining features where added in future versions, like 2.1.1 and so on? I understand the relvance of semver, but it's a pity if it ends up delaying the release of important features that are ready. Also, is there a way to access the 'canary' branch from npm? Thanks! |
@pensierinmusica you can generate it and use it locally by cloning it and checking out |
@kevinawoo, yep thanks, that's what I ended up doing! :) |
For the love of god, please roll this out already! |
@rayokota support seems to be in the main branch. I have been playing with a prototype using Postgres and it is going well. The sqlite3 build on Fedora 22 x86_64 failed to compile, but PG is great. |
We should be able to select between using mongodb with mongoose, or sql with sequelize.
The text was updated successfully, but these errors were encountered: