Skip to content

Generate Passport boilerplate independent of db (instead of only for MongoDB) #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melo0187 opened this issue Jun 2, 2014 · 8 comments

Comments

@melo0187
Copy link

melo0187 commented Jun 2, 2014

It would be awesome if angular-fullstack could support to generate the Passport boilerplate independently of Mongo. If you answered yes to Mongo it does everything the same way it is right now, but if you answered no it would instead generate the Passport boilerplate with Sequelize, so that one could drop in MySQL, PostgreSQL or whatever.

I found a little about Passport - Sequelize - PostgreSQL over here: http://sarabinns.com/tag/passport-js-sequelize-postgresql/

Right now I try to setup a project with AngularJS in the front-end and Express in the back-end and to write an api that queries a PostgreSQL DB and returns it's results to the AngularJS client with the help of pg and pg-query. Actually I got this running already but am struggling to drop in Passport.

@JaKXz JaKXz added the question label Jun 2, 2014
@JaKXz
Copy link
Collaborator

JaKXz commented Jun 2, 2014

Hi @melo0187, I appreciate you searching through the issues and finding #94. I think your question would be better phrased as "Generate Passport boilerplate independent of db", as @iqrow commented so that it would apply to the general case.

I'd also invite you to look into a PR like I suggested here, what do you think?

@melo0187 melo0187 changed the title New Feature: Generate Passport boilerplate with Sequelize (instead of Mongo) Generate Passport boilerplate independent of db (instead of only for MongoDB) Jun 2, 2014
@melo0187
Copy link
Author

melo0187 commented Jun 2, 2014

Hi @JaKXz, thanks for your reply.

First of all: Sorry for reposting. Since #94 is closed I did not know if I would have ever gotten any response. This occured to me only after commenting on #94. I did not mean to litter the issues list...
(-_-;)

I renamed the issue according to your suggestion.

Do you mean PR as pull request? I wish I could help, but I'm actually quite a noob. I only used AngularJS and Yeoman a little before and am completely new to ExpressJS. I'm actually using your generator for a new project as a way of learning. I have no idea how Yeoman generators work. Would it also help to upload a project that is based on what angular-fullstack generates, modified by hand to use Sequelize (implying that I could manage to get this done right)?

@JaKXz
Copy link
Collaborator

JaKXz commented Jun 2, 2014

@melo0187 no worries, questions are welcome 😄

Yes, PR = pull request (guidelines), meaning that I would challenge you to learn more about Yeoman generators and how they work as well as the technology in this stack (Mongo + Express + Angular + Node) and come up with a solution that could be integrated into this project. We were all noobs once (and I technically still am one) so you're in the right place by just trying stuff and learning everything. A link to what you have so far would certainly make it easier to assist you.

I'd suggest going through the Passport docs once more to help you with the project you mentioned. You can use a project that's generated here (without Mongo of course) as your guide.

@melo0187
Copy link
Author

melo0187 commented Jun 2, 2014

@JaKXz challenge accepted 😆

I will have to split this into two parts since the amount of new stuff is quite overwhelming.
I will try to get my project up and running with Passport. It's based on angular-fullstack (yes to all except Sass and MongoDB) and using pq and pq-query for the PostgreSQL database, which is working nicely so far.
If I should succeed I will fork your repo and learn how this generator is working it's magic =) (and I will probably try to do this even when failing with step 1, just for the fun)

@JaKXz JaKXz added wontfix and removed question labels Jul 4, 2014
@JaKXz
Copy link
Collaborator

JaKXz commented Jul 10, 2014

Apologies for the mis-label before. How're things going @melo0187, you've considered the changes in 2.x right?

@melo0187
Copy link
Author

@JaKXz right now my project is focusing on the public part and providing visualization of the data using charts, so I was very busy with that and not able get started with the Passport integration...

Also I did not update the generator yet. Can I simply update the generator and continue to use it for my project generated with version 1.4.x or do I need to migrate my project to the new structure by hand?

Is there a changelog so I can get an idea of what the changes from 1.4.x to 2.0.x are?
Edit: Never mind. Just found the changelog.md. Still from what I understand right now I should consider updating the generator, generating a project with the new structure and migrate my stuff to this new project, right?

@JaKXz
Copy link
Collaborator

JaKXz commented Jul 14, 2014

Have a look at the wiki as well. ATM you'll have to move everything over manually.

@JaKXz
Copy link
Collaborator

JaKXz commented Aug 10, 2014

Closing with #414.

@JaKXz JaKXz closed this as completed Aug 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants