Skip to content

Fix escape bug #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Fix escape bug #25

merged 1 commit into from
Jan 3, 2021

Conversation

Vinx911
Copy link
Contributor

@Vinx911 Vinx911 commented Dec 31, 2020

https://github.com/espressif/esptool/wiki/Serial-Protocol#low-level-protocol
Each SLIP packet begins and ends with 0xC0. Within the packet, all occurrences of 0xC0 and 0xDB are replaced with 0xDB 0xDC and 0xDB 0xDD, respectively. The replacing is to be done after the checksum and lengths are calculated, so the packet length may be longer than the size field below.

reply += b"\xDC" ===>> reply += b"\xDB"

@ladyada
Copy link
Member

ladyada commented Jan 3, 2021

Each SLIP packet begins and ends with 0xC0. Within the packet, all occurrences of 0xC0 and 0xDB are replaced with 0xDB 0xDC and 0xDB 0xDD, respectively. The replacing is to be done after the checksum and lengths are calculated, so the packet length may be longer than the size field below.

@ladyada ladyada merged commit 0796387 into adafruit:master Jan 3, 2021
@ladyada
Copy link
Member

ladyada commented Jan 3, 2021

thanx!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 6, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.4 from 3.5.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#122 from anecdata/disconnect

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.1.4 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#19 from tmf97/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS35HW to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LPS35HW#8 from adafruit/temp_sign_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 4.0.0 from 3.6.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#97 from flavio-fernandes/get_local_time.exception.merge

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.3 from 3.10.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#88 from agarthetiger/st7789-docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.3.2 from 2.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#23 from codingbandit/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#34 from jepler/big-metrics

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.0.2 from 5.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#63 from BiffoBear/add-0x-to-error-msg

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.5.3 from 1.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#48 from benetherington/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 2.0.0 from 1.9.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#55 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.2.6 from 0.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#25 from Vinx911/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants