Ported over to use PortalBase #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this PR is merged, some guide updates will need to be made. Mostly the MatrixPortal guide which shows that you'll also need the PortalBase and FakeRequests libraries and the Creating MatrixPortal Projects guide will need to be updated as the structure/layout will be different. Please keep this in mind if merging while I'm out. |
|
I'm back, so feel free to merge at any time. This might fix some of the issues that have opened up since. |
ladyada
approved these changes
Jan 5, 2021
|
didnt test! |
|
Thanks! |
|
MatrixPortal and MatrixPortal Projects guides are now updated to reflect the refactor. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 6, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.4 from 3.5.3: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#122 from anecdata/disconnect Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.1.4 from 2.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#19 from tmf97/master Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS35HW to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_LPS35HW#8 from adafruit/temp_sign_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 4.0.0 from 3.6.2: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#97 from flavio-fernandes/get_local_time.exception.merge Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.3 from 3.10.2: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#88 from agarthetiger/st7789-docs Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.3.2 from 2.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#23 from codingbandit/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#34 from jepler/big-metrics Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.0.2 from 5.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#63 from BiffoBear/add-0x-to-error-msg Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.5.3 from 1.5.2: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#48 from benetherington/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 2.0.0 from 1.9.6: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#55 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.2.6 from 0.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#25 from Vinx911/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good chunk of the functionality was removed from here that is part of PortalBase. I tested this on a few examples (specifically scrolling quotes, weather, and halloween countdown) and all worked perfectly with no modifications. Some functionality was moved from Network to WiFi in the initialization because it was specific to the ESP32 Coprocessor and the requests library and shouldn't affect functionality, so no code modifications on examples or user code should be necessary.