Skip to content

Fixes issue #7 whereby the read method should be renamed to raw_uv #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2019

Conversation

WindFishDiety
Copy link
Contributor

Addressing #7
Updated code, comments and sample code.
Testing would be required

@caternuson caternuson requested a review from a team May 9, 2019 01:13
Copy link
Contributor

@caternuson caternuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My suggestions are essentially cosmetic.

sommersoft
sommersoft previously approved these changes May 9, 2019
Copy link
Collaborator

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix @WindFishDiety!

@sommersoft sommersoft dismissed their stale review May 9, 2019 02:11

stale webpage...didn't see cater's review.

@WindFishDiety
Copy link
Contributor Author

Hey thanks for letting me participate in the pycon sprints.

@tannewt tannewt requested a review from caternuson May 10, 2019 20:52
Copy link
Contributor

@caternuson caternuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks. Looks good!

@caternuson caternuson merged commit 7b6fa1d into adafruit:master May 11, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 11, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 3.1.0 from 3.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#29 from caternuson/webgl

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.3.1 from 0.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#29 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303 to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303#12 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.3.7 from 3.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#45 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PN532 to 2.0.5 from 2.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PN532#22 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.0.0 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#8 from WindFishDiety/UVReadRaw

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.0.9 from 1.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#11 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.11 from 2.2.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#28 from dherrada/master
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#27 from adafruit/revert-25-add-blinka-to-requirements-txt

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.1.1 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#9 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.4.2 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#26 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.7.1 from 1.7.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#25 from dherrada/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants