Skip to content

Rename read to raw_value #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tannewt opened this issue Mar 27, 2019 · 2 comments
Closed

Rename read to raw_value #7

tannewt opened this issue Mar 27, 2019 · 2 comments

Comments

@tannewt
Copy link
Member

tannewt commented Mar 27, 2019

read is a property but the name is a verb (aka action). Only function names should include verbs. The read property should be raw_uv, raw_value or similar nouns.
@ladyada
Copy link
Member

ladyada commented Mar 27, 2019

@sommersoft heya i think you propertified this code, did you want to unpropertify?

WindFishDiety added a commit to WindFishDiety/Adafruit_CircuitPython_VEML6070 that referenced this issue May 8, 2019
@WindFishDiety
Fixes issue adafruit#7 whereby the read method should be renamed to r…
335bebc 
…aw_uv
@WindFishDiety WindFishDiety mentioned this issue May 8, 2019
Merged
caternuson added a commit that referenced this issue May 11, 2019
@caternuson
Merge pull request #8 from WindFishDiety/UVReadRaw
7b6fa1d 
Fixes issue #7 whereby the read method should be renamed to raw_uv
@caternuson
Copy link
Contributor

Fixed by #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tannewt @ladyada @caternuson