doc(mypy): Add type annotations to function defintions #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
requested changes
Oct 7, 2021
There was a problem hiding this comment.
Thanks for working on this @careyk007. I have suggestions on a few of them.
|
@FoamyGuy Thanks for the review! I added the additional types and some import statements to make the types available. |
FoamyGuy
approved these changes
Oct 8, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 13, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#29 from FoamyGuy/type_info > Globally disabled consider-using-f-string pylint check Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.2.2 from 6.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#119 from jsymons/typing > Globally disabled consider-using-f-string pylint check Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.10.0 from 1.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#85 from ladyada/master > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#81 from FoamyGuy/use_rainbowio > Globally disabled consider-using-f-string pylint check Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.12.2 from 2.12.1: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#69 from careyk007/add_missing_type_annotations > Globally disabled consider-using-f-string pylint check Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.2 from 1.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#27 from helgibbons/Display-Pack-2.0 > Globally disabled consider-using-f-string pylint check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken a stab at #68.
I tried to figure out the correct types and avoid the use of
Anyas much as possible. I can try to dig deeper and remove some of the remainingAnys if that would be helpful.I ran the command
mypy --disallow-untyped-defs --disallow-incomplete-defs --ignore-missing-imports adafruit_ssd1306.pyfor verification and received the following output:I visually checked these occurrences and they are only indexed if they are not set to
None, so I think it is acceptable to ignore these errors.