Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #28
I am not certain whether using
Any
is the best option for**kwargs
but there are many different possible types of the various different arguments that can get passed that way. I tried using some of the specific types but mypy still reported errors. I'm not sure if we have another option beyond breaking out all of the possible arguments and declaring types for all of them. I'm still pretty new to typing in python though, perhaps I've overlooked something or someone else has ideas.There is possibly something that still needs done to make the sphinx docs correct. When building locally I'm not seeing the proper arguments for init(). But strangely when I build the docs from
main
I'm seeing the same issue. So perhaps there is some difference in my environment vs. in actions.I tested this driver successfully with a Raspberry Pi B+ using Blinka_Displayio