Skip to content

Cleanly request i2c_device with page addressing #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

adamcandy
Copy link
Contributor

Fixes the locking error reported in #40.

@tannewt tannewt requested a review from jposada202020 April 30, 2021 17:50
@jposada202020
Copy link
Contributor

@adamcandy Thank you! for all the explanation, the fix, and all the hard work

I have tested this in

Adafruit CircuitPython 6.2.0-beta.3-188-g05ed179e1 on 2021-03-15; Adafruit Feather RP2040 with rp2040

For results and pictures see #40. Fix to the device hanging after using page load is fixed by this PR.

Thanks again!

@jposada202020 jposada202020 merged commit 1473957 into adafruit:master Apr 30, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 5, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#15 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.2 from 2.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#49 from jposada202020/veryfing_references
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#47 from jposada202020/changing_busio_definition

Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.6.1 from 3.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#71 from jposada202020/updating_readme
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#70 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.7 from 2.4.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#35 from jposada202020/product_info_and_note_changes

Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#16 from jposada202020/verifying_references
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#15 from jposada202020/correcting_CV_reference
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#14 from jposada202020/correcting_example_name

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.1.9 from 2.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#23 from jposada202020/correcting_assertions

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.1.8 from 2.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#24 from jposada202020/correction_assertions

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.1.5 from 4.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#40 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCT2075 to 1.1.10 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCT2075#18 from jposada202020/veryfing_references
  > Merge pull request adafruit/Adafruit_CircuitPython_PCT2075#17 from jposada202020/adding_board.I2C_reference

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.1.0 from 2.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#15 from jraber/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT4x to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHT4x#5 from jposada202020/adding_board.I2C_definition

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#10 from jposada202020/adding_board.I2C_definition

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.11.3 from 2.11.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#61 from adamcandy/fix-locking-error
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.3.7 from 3.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Thermistor#17 from jposada202020/adding_Learning_Guide_reference

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV493D to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLV493D#12 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TM#5 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#14 from jposada202020/adding_doc_parameters
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#16 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.18.4 from 2.18.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#151 from jposada202020/updating_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.0.0 from 4.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#66 from dhalbert/remove-gamepad

Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 2.1.0 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#29 from jposada202020/adding_color_scale_example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants