Skip to content

move gamepad.py to examples #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2021
Merged

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented May 4, 2021

In CircuitPython 7.0.0, there will no longer be a builtin Gamepad HID device. Instead, you will be able to supply your own HID descriptors for whatever kind of gamepad you want.

This removes gamepad.py from the library, and move it to examples/, with very slight changes. Once dynamic USB descriptors is in a 7.0.0 alpha or beta release, I will update the example to include details of creating an example gamepad usb_hid.Device, or else move it to a new library.

I looked in the Learn Guides, and there are none that use the current Gamepad functionality. So I think it's safe to remove the functionality from the current library. It will receive a major version increment. The current Gamepad only works on Windows. It may work slightly on MacOS, but it can interfere with the mouse. It does not work on Linux.

Removing Gamepad has the additional advantage of saving 2.6kB in frozen library space on those boards that freeze HID. This space will be very helpful in compensating for the additional firmware space needed for the new Circuitpyon 7.0.0 dynamic USB code.

@dhalbert dhalbert requested a review from a team May 4, 2021 21:13
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did not test.

@dhalbert dhalbert merged commit de68b7d into adafruit:master May 4, 2021
@dhalbert dhalbert deleted the remove-gamepad branch May 4, 2021 21:47
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 5, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#15 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.2 from 2.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#49 from jposada202020/veryfing_references
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#47 from jposada202020/changing_busio_definition

Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.6.1 from 3.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#71 from jposada202020/updating_readme
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#70 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.7 from 2.4.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#35 from jposada202020/product_info_and_note_changes

Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#16 from jposada202020/verifying_references
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#15 from jposada202020/correcting_CV_reference
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#14 from jposada202020/correcting_example_name

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.1.9 from 2.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#23 from jposada202020/correcting_assertions

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.1.8 from 2.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#24 from jposada202020/correction_assertions

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.1.5 from 4.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#40 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCT2075 to 1.1.10 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCT2075#18 from jposada202020/veryfing_references
  > Merge pull request adafruit/Adafruit_CircuitPython_PCT2075#17 from jposada202020/adding_board.I2C_reference

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.1.0 from 2.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#15 from jraber/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT4x to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHT4x#5 from jposada202020/adding_board.I2C_definition

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#10 from jposada202020/adding_board.I2C_definition

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.11.3 from 2.11.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#61 from adamcandy/fix-locking-error
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.3.7 from 3.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Thermistor#17 from jposada202020/adding_Learning_Guide_reference

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV493D to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLV493D#12 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TM#5 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#14 from jposada202020/adding_doc_parameters
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#16 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.18.4 from 2.18.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#151 from jposada202020/updating_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.0.0 from 4.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#66 from dhalbert/remove-gamepad

Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 2.1.0 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#29 from jposada202020/adding_color_scale_example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants