Skip to content

Fixed Issue #11 with Samsung EVO 32GB cards #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2019

Conversation

devoh747
Copy link
Contributor

@devoh747 devoh747 commented Aug 7, 2019

and also added dynamic CRC checking

and also added dynamic CRC checking
@devoh747
Copy link
Contributor Author

devoh747 commented Aug 7, 2019

why is this failing? It's working on my board(GrandCentral).. or is this to do with the mess I made of the PR's and deleting my repo?

@makermelissa
Copy link
Collaborator

It looks like it's failing at Pylint, which makes sure your code is consistent. You should be able to see the build log by clicking some links to see the travis logs.

Here's the particular lines:

C:474, 0: Exactly one space required after comma
            for _ in range(1,8):
                            ^ (bad-whitespace)
C:459, 4: Missing method docstring (missing-docstring)
C:464, 8: Variable name "CRCTable" doesn't conform to '(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$' pattern (invalid-name)
C:466, 8: Variable name "CRCPoly" doesn't conform to '(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$' pattern (invalid-name)
C:479, 8: Variable name "CRC" doesn't conform to '(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$' pattern (invalid-name)
C:480, 8: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
C:481,12: Variable name "CRC" doesn't conform to '(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$' pattern (invalid-name)
R:459, 4: Method could be a function (no-self-use)

@devoh747
Copy link
Contributor Author

devoh747 commented Aug 8, 2019

ok I fixed the pylint issues and committed it to my branch.. will it automatically be picked up here?

devoh747 added 2 commits August 7, 2019 20:40
Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
@devoh747
Copy link
Contributor Author

devoh747 commented Aug 8, 2019

Here is a test program to show how I calculated
the static CRC command codes.. and to verify my dynamic CRC generation code.
crc_verification_code.py.txt

@tannewt tannewt self-requested a review August 16, 2019 17:49
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants