Support PWM output. #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make the RTTTL parsing more resilient to whitespace and capitalized notes.
kattni
approved these changes
Mar 23, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 24, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.1.0 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#5 from tannewt/pwm_support > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#4 from sommersoft/new_docs
|
I think it would be much cleaner to have a separate function (or class) for playing a specified tone for a specified duration (like Arduino's |
|
Yeah, I agree using something like simple.tone would be better. I was under
a time cruch so I just redid it. This does have the advantage of grabbing
the resources once for the whole tune.
…On Sat, Mar 24, 2018 at 4:16 AM Radomir Dopieralski < ***@***.***> wrote:
I think it would be much cleaner to have a separate function (or class)
for playing a specified tone for a specified duration (like Arduino's
tone() for example), and then just provide two implementations of it, and
do dependency injection depending on whether DAC is available on the given
pin or not.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADNqaUZ9QrhCHQP45N0pM1hICUW8L1Jks5thisAgaJpZM4S5Y7b>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make the RTTTL parsing more resilient to whitespace and
capitalized notes.