Skip to content

updated for pylint and adding examples folder #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2018

Conversation

mrmcwethy
Copy link
Collaborator

#adafruit/circuitpython#475
#adafruit/circuitpython#493

I was going to fix up the examples, but saw the it had not been pylinted yet, so i did that too.

@brentru
Copy link
Member

brentru commented Jan 3, 2018

Tested on:
Adafruit CircuitPython 2.1.0 on 2017-10-17; Adafruit Metro M0 Express with samd21g18
It's a bit too quiet playing out of the Piezo on A0 (connected to DAC).

@ladyada
Copy link
Member

ladyada commented Jan 3, 2018

@tannewt heya im having brent looking to add piezo-support (square wave on pulseio) for trinket/gemma/otherpin support?

@tannewt tannewt self-requested a review January 5, 2018 17:59
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! @brentru please rebase your PR onto this.

@tannewt tannewt merged commit 0339a1c into adafruit:master Jan 5, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 19, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.1.0 from 1.0.0:
  > Added examples folder and examples file (adafruit/Adafruit_CircuitPython_IS31FL3731#7)
  > [adafruit/Adafruit_CircuitPython_IS31FL3731#3] Remove "TODO" and add description with supported hardware.
  > [adafruit/Adafruit_CircuitPython_IS31FL3731#3] Enable Python syntax highlighting in README examples.
  > [adafruit/Adafruit_CircuitPython_IS31FL3731#3] Remove "TODO" from README.

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.1.0 from 3.0.0:
  > added examples folder and .py file

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.1.0 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#15 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 2.1.0 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#9 from Sigafoos/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.1.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#8 from mrmcwethy/examples
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#7 from tannewt/lint

Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.0.0 from 0.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#1 from mrmcwethy/addexamples

Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.1.0 from 1.0.0:
  > added demos for square and sine, fixed square per comment
  > added a square waveform generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants