Skip to content

Update README to remove TODO #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tannewt opened this issue Sep 6, 2017 · 5 comments
Closed

Update README to remove TODO #3

tannewt opened this issue Sep 6, 2017 · 5 comments
Labels
good first issue

Comments

@tannewt
Copy link
Member

tannewt commented Sep 6, 2017

Also get examples highlighted as Python
tannewt pushed a commit that referenced this issue Oct 8, 2017
@process1183 @tannewt
[#3] Remove "TODO" from README.
ac981a1
tannewt pushed a commit that referenced this issue Oct 8, 2017
@process1183 @tannewt
[#3] Enable Python syntax highlighting in README examples.
56696be
@tannewt
Copy link
Member Author

tannewt commented Oct 8, 2017

The TODO is still there actually but the code is highlighted. The TODO should not only be removed but replaced with a description of the hardware the driver supports.

@process1183
Copy link
Contributor

It looks like I somehow accidentally re added the TODO in the syntax highlighting commit (707be7b), which I made after committing the TODO remove (fc69fef). Oops.

@process1183
Copy link
Contributor

I'm working on replacing the "TODO" with a short description and supported hardware. How does this look?

CircuitPython driver for the IS31FL3731 charlieplex IC.

This driver supports the following hardware:

* `Adafruit 16x9 Charlieplexed PWM LED Matrix Driver - IS31FL3731 <https://www.adafruit.com/product/2946>`_
* `Adafruit 15x7 CharliePlex LED Matrix Display FeatherWings <https://www.adafruit.com/product/2965>`_

@tannewt
Copy link
Member Author

tannewt commented Oct 8, 2017 via email

tannewt pushed a commit that referenced this issue Oct 8, 2017
@process1183 @tannewt
[#3] Remove "TODO" and add description with supported hardware.
16dd6ca
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this issue Jan 19, 2018
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@812c633)
ae7acce 
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.1.0 from 1.0.0:
  > Added examples folder and examples file (adafruit/Adafruit_CircuitPython_IS31FL3731#7)
  > [adafruit/Adafruit_CircuitPython_IS31FL3731#3] Remove "TODO" and add description with supported hardware.
  > [adafruit/Adafruit_CircuitPython_IS31FL3731#3] Enable Python syntax highlighting in README examples.
  > [adafruit/Adafruit_CircuitPython_IS31FL3731#3] Remove "TODO" from README.

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.1.0 from 3.0.0:
  > added examples folder and .py file

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.1.0 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#15 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 2.1.0 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#9 from Sigafoos/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.1.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#8 from mrmcwethy/examples
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#7 from tannewt/lint

Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.0.0 from 0.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#1 from mrmcwethy/addexamples

Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.1.0 from 1.0.0:
  > added demos for square and sine, fixed square per comment
  > added a square waveform generator
@tannewt
Copy link
Member Author

tannewt commented Jan 24, 2018

Done in https://github.com/process1183/Adafruit_CircuitPython_IS31FL3731/commit/cb21ee2fe22a8496adfa076d6bbb9dea8ff1204a. Thanks @process1183

@tannewt tannewt closed this as completed Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tannewt @process1183