-
Notifications
You must be signed in to change notification settings - Fork 53
Add missing time import in example #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copy/pasted, the example otherwise doesn't run due to the usage of `time.sleep` in the code.
This is a tiny issue I discovered along the way. It seemed simple and obvious enough to send a pull request without opening an issue first. Hope that's alright. |
makermelissa
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 26, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.1.5 from 1.1.4: > Update README.rst > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#20 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#19 from siqueira-ec/master Updating https://github.com/adafruit/Adafruit_CircuitPython_DS2413 to 1.1.4 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#12 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#11 from rhooper/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#12 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#11 from dsudduth/master Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.1.0 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#16 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#15 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.3.0 from 3.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_INA219#14 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_INA219#13 from wallarug/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.2.2 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#22 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#21 from rhooper/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.7.0 from 3.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#50 from Johennes/feature/subscreen > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#52 from Johennes/feature/readme Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#3 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#2 from urish/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.1.6 from 3.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#11 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#10 from rhooper/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.2.1 from 1.2.0: > Update README.rst > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#14 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#13 from abkosar/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BoardTest to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_BoardTest#8 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_BoardTest#7 from om8007/fix-issue6 Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.0.1 from 4.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#34 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#32 from huyle1097/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#34 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_Motor#33 from william3031/master Updating https://github.com/adafruit/Adafruit_CircuitPython_OneWire to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#15 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#13 from sreekaran16/patch-2 Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.3.1 from 2.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#17 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#16 from rhooper/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#50 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#49 from ilmanzo/simpleio_map_range_simpletest Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.2.5 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#14 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#13 from abkosar/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copy/pasted, the example otherwise doesn't run due
to the usage of
time.sleep
in the code.