Skip to content

Replaced building locally section with documentation section #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2019
Merged

Replaced building locally section with documentation section #34

merged 3 commits into from
Oct 25, 2019

Conversation

evaherrada
Copy link
Collaborator

kattni
kattni suggested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dherrada I'm not sure why you closed the other one to open this one. We still need the changes requested on the other one. It needs PyPI instructions, and it needs the Installation section removed. You can make the changes on this PR.

@evaherrada
Copy link
Collaborator Author

@kattni Sorry about that. I got confused and thought you were referring to removing the "installing from pypi" section instead of the "installation" section.

@evaherrada evaherrada requested a review from kattni October 24, 2019 13:57
kattni
kattni suggested changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! There are two whitespace issues, see inline comments. Get those fixed up and it's ready to merge.

README.rst
pip3 install adafruit-circuitpython-busdevice

To install system-wide (this may be required in some cases):
.. code-block:: shell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a blank line between this and the line above it.

README.rst
sudo pip3 install adafruit-circuitpython-busdevice

To install in a virtual environment in your current project:
.. code-block:: shell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a blank line between this and the line above it.

@evaherrada evaherrada requested a review from kattni October 25, 2019 02:27
@kattni kattni merged commit cf7eabc into master Oct 25, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 26, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@f7bbfc2)
ac61811 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.1.5 from 1.1.4:
  > Update README.rst
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#20 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#19 from siqueira-ec/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS2413 to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#12 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#11 from rhooper/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#12 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#11 from dsudduth/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.1.0 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#16 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#15 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.3.0 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA219#14 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_INA219#13 from wallarug/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.2.2 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#22 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#21 from rhooper/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.7.0 from 3.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#50 from Johennes/feature/subscreen
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#52 from Johennes/feature/readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.1.0 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#3 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#2 from urish/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.1.6 from 3.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#11 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#10 from rhooper/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.2.1 from 1.2.0:
  > Update README.rst
  > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#14 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#13 from abkosar/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BoardTest to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BoardTest#8 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BoardTest#7 from om8007/fix-issue6

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.0.1 from 4.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#34 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#32 from huyle1097/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#34 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#33 from william3031/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_OneWire to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#15 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#13 from sreekaran16/patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.3.1 from 2.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#17 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#16 from rhooper/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 2.0.2 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#50 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#49 from ilmanzo/simpleio_map_range_simpletest

Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#14 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#13 from abkosar/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evaherrada @kattni