Fixing error, WaveFile moved to audiocore

[fede2cr]

I was testing the new json library and with this particular branch of circuitpython, but also with the latest from main, i was getting the following error while testing with the PyPortal:

Traceback (most recent call last):
File "code.py", line 35, in
File "/lib/adafruit_pyportal.py", line 284, in init
File "/lib/adafruit_pyportal.py", line 282, in init
File "/lib/adafruit_pyportal.py", line 633, in play_file
AttributeError: 'module' object has no attribute 'WaveFile'

Checking the docs, it looks like WaveFile moved to audiocore.
This couple of line fixes the problem and allow the PyPortal object to be created, and example pyportal code now works ok.

[fede2cr]

Note: This is intended to be applied for a 6.x release. If you use it as is on 5.3.x it does not know the module audiocore.

[FoamyGuy]

I think if we add audiocore to this list of mock imports in the docs conf.py file here:

Adafruit_CircuitPython_PyPortal/docs/conf.py

Line 24 in 5df5d04

autodoc_mock_imports = [

it might resolve the current actions issue.

[fede2cr]

I just added the change to fede2cr:master. I don't see github re-doing the checks after this commit/push. Not sure if I did something wrong, or am I just being impatient with github.

[FoamyGuy]

That is weird I see your new commit/push on your branch, but it's not showing up here.

As far as I can tell you did make that new commit / push correctly. My guess is perhaps github and/or the actions system is having some kind of issue at the moment. Hopefully it will resolve itself shortly.

[FoamyGuy]

This looks good to me. Thank you for making these updates to the new API.

It does work on some versions 5.3.0 and below. I tested it down to 5.0.0 and it was working correctly there as well.

[FoamyGuy]

I did a bit more testing and it looks like 5.0.0 was the oldest version that this works with. On 4.1.2 it crashes because audiocore does not exist yet.

I think this is okay to merge and release now. When we release it we should probably bump the major version and make a note that it's incompatible with Circuit Python versions below 5.0.0.

I'm going to leave it for now to see if anyone has thoughts or objections but we can merge it soon if there are no concerns.

[tannewt]

Looks good to me! Thanks!

[tannewt]

Also note, we no longer make 4.x bundles so folks won't get this version that way.