Skip to content

PCF8523: Add additional registers #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 20, 2020

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Jul 16, 2020

This adds the following registers:

  • cap_sel, True to add additional capacitance to clock pins
  • calibration_mode, select one of two different clock calibration methods
  • calibration, set the clock calibration (offset) value in ~4ppm steps

By accurately measuring the crystal frequency, these values can be selected to improve the calibration of the RTC from "minutes per month" to "seconds per month".

This depends on adafruit/Adafruit_CircuitPython_Register#39 as the "calibration" register holds a signed value, so it should not be accepted until that PR is accepted.

jepler added 3 commits July 15, 2020 21:33
This adds the following registers:
 * cap_sel, True to add additional capacitance to clock pins
 * calibration_mode, select one of two different clock calibration methods
 * calibration, set the clock calibration (offset) value in ~4ppm steps

By accurately measuring the crystal frequency, these values can be
selected to improve the calibration of the RTC from "minutes per month"
to "seconds per month".
@jepler
Copy link
Contributor Author

jepler commented Jul 16, 2020

Pylint will error about the use of the "signed" kw parameter until the related PR in Adafruit_CircuitPython_Register is merged.

@jepler jepler marked this pull request as ready for review July 19, 2020 16:41
@jepler jepler requested a review from tannewt July 19, 2020 16:45
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit aa0f0df into adafruit:master Jul 20, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 22, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.0 from 2.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#27 from jepler/calibration-and-temperature

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.5.0 from 1.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#19 from jepler/calibration-registers

Updating https://github.com/adafruit/Adafruit_CircuitPython_PM25 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PM25#3 from dglaude/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.3.0 from 3.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#82 from fede2cr/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#44 from 2bndy5/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 1.3.0 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#8 from FoamyGuy/performance_boost

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.5.0 from 1.4.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#29 from brentru/update-cellular-3g
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants