-
Notifications
You must be signed in to change notification settings - Fork 16
PCF8523: Add additional registers #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the following registers: * cap_sel, True to add additional capacitance to clock pins * calibration_mode, select one of two different clock calibration methods * calibration, set the clock calibration (offset) value in ~4ppm steps By accurately measuring the crystal frequency, these values can be selected to improve the calibration of the RTC from "minutes per month" to "seconds per month".
Pylint will error about the use of the "signed" kw parameter until the related PR in Adafruit_CircuitPython_Register is merged. |
tannewt
reviewed
Jul 17, 2020
Co-authored-by: Scott Shawcroft <[email protected]>
tannewt
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 22, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.0 from 2.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#27 from jepler/calibration-and-temperature Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.5.0 from 1.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#19 from jepler/calibration-registers Updating https://github.com/adafruit/Adafruit_CircuitPython_PM25 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_PM25#3 from dglaude/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.3.0 from 3.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#82 from fede2cr/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 3.2.2 from 3.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#44 from 2bndy5/master Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 1.3.0 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#8 from FoamyGuy/performance_boost Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.5.0 from 1.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#29 from brentru/update-cellular-3g
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following registers:
By accurately measuring the crystal frequency, these values can be selected to improve the calibration of the RTC from "minutes per month" to "seconds per month".
This depends on adafruit/Adafruit_CircuitPython_Register#39 as the "calibration" register holds a signed value, so it should not be accepted until that PR is accepted.