Adding an URL-based image path kwarg to PyPortal #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2019 13:42
ladyada
approved these changes
Apr 23, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 25, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.3.7 from 1.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#39 from brentru/update-simpletest > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#38 from cpforbes/add_gpio > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#34 from docmollo/docs_wpa2_enterprise Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#27 from brentru/add-image-http-path > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#26 from DigitalMakerCIC/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
image_url_pathto PyPortal to allow directly setting a non-json image path for API endpoints or websites without a JSON response with a provided image url (i.e: https://ddragon.leagueoflegends.com/cdn/9.6.1/img/profileicon/$Identifier.png)