Skip to content

Updating simpletest/aio_send - adding externally defined pins for breakout, etc #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 25, 2019
Merged

Updating simpletest/aio_send - adding externally defined pins for breakout, etc #39

merged 7 commits into from
Apr 25, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Apr 25, 2019 •
edited
Loading

Adding externally defined pins to simpletest and aio send. Changing PyPortal to "board with pre-defined ESP32 pins" to support boards like the Metro M4 WiFi.

@brentru brentru requested a review from a team April 25, 2019 16:32
@brentru brentru changed the title Updating simpletest - adding externally defined pins for breakout, etc Updating simpletest/aio_send - adding externally defined pins for breakout, etc Apr 25, 2019
@brentru brentru requested a review from jerryneedell April 25, 2019 16:47
jerryneedell
jerryneedell approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me -- I like the change to the pre-defined pins as the default. I have not tested the changes, but don't see any problem with them.

kattni
kattni suggested changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. Small request: Please use the # method to comment out the pin lines as well - that's how we've done it previously and consistency is good.

@brentru
Copy link
Member Author

brentru commented Apr 25, 2019

@kattni Ok, updated to use # comments.

kattni
kattni approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@kattni kattni merged commit 318c7ae into adafruit:master Apr 25, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 25, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@430d8ab)
9f8d163 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.3.7 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#39 from brentru/update-simpletest
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#38 from cpforbes/add_gpio
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#34 from docmollo/docs_wpa2_enterprise

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 2.1.1 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#27 from brentru/add-image-http-path
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#26 from DigitalMakerCIC/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brentru @kattni @jerryneedell