rename mag_tag to magtag. Fix neopixel power pin handling #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeithTheEE
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Tested on two different magtags. It performed identically and correctly on both.
The only point that stood out to me is the comments say use Buttons A, B, and C, however the silkscreen titles them D15/D14/D12 respectively. But this solves the Neopixel power pin bug and I don't know if the button naming is intentional.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 15, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.5.0 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#37 from FlantasticDan/chainable-matrices > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.6.1 from 3.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#56 from FoamyGuy/rename_mag_tag > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#54 from FoamyGuy/pybadge_lc_compatibility > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the
mag_tag.pyfile tomagtag.py. That turned out to not require any external changes because of the way this library is structured. user-code will always import like:And internally inside of
__init__.pyit figures out which device it is running on and imports from the correct subclass file.So there should not be any user code that would have ever needed to import pybadger.mag_tag directly. I grepped the Learn Guide repo to double check and did not find any instances that would require changing.
This PR also removes the handling of NEOPIXEL_POWER pin from the magtag example as that is now handled automatically inside of the neopixel library. This change resolves: #55
I tested this version successfully on: