Pybadge LC compatibility #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to cancel the current actions workflow for this PR because sphinx is stuck in an infinite loop due to the |
|
Alright. It's' passing actions checks now. I changed the Re-tested with the latest version on EdgeBadge and acceleration readings do still work properly on that device. |
kattni
approved these changes
Dec 13, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 15, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.5.0 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#37 from FlantasticDan/chainable-matrices > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.6.1 from 3.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#56 from FoamyGuy/rename_mag_tag > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#54 from FoamyGuy/pybadge_lc_compatibility > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #53
This change will run an
i2c.scan()and check for the presence of the accelerometer (addresses0x18or0x19) before attempting to initialize it. I believe this should make the library compatible with the PyBadge LC variant which does not have the accelerometer populated.I tested the updated library using the simpletest with an Edge Badge to ensure that accelerometer readings are still working normally.
I don't have the LC variant of the hardware. But it would be great if someone who does can test this change on it as well to ensure there isn't something I missed still causing incompatibility.