PortalBase refactoring to work with PyPortal better #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
requested changes
Jan 9, 2021
There was a problem hiding this comment.
I tested this with MagTag using a few of my own projects and the scripts in examples folder of MagTag repo. Everything is working successfully.
Changes look good to me aside from two small things to cleanup. I could do these in a followup PR also if it helps.
|
I will test the #99 in PyPortal repo with this today as well. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 12, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 5.0.0 from 4.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#99 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#100 from makermelissa/fix-precommit > Added pre-commit-config file > Added pre-commit and SPDX copyright Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_TM#1 from adeanzan/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.0.3 from 5.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#61 from mstaack/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#8 from makermelissa/main
This was referenced Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored PortalBase in order to better facilitate using it with PyPortal. With these changes, no additional changes should be required for the MagTag and MatrixPortal libraries. This was more about splitting some of the sections of fetch into smaller chunks so it was easier to make a higher level function that could call these chunks when needed.