SPI has no address #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
its true! however, now pylint has a complaint... |
|
Weird. Looks like there was an attempt to turn that check off. Wonder why it's only failing now. Maybe need to move the disable up a bit in scope? except OSError:
# some OS's dont like writing an empty bytesting...
# Retry by reading a byte
# pylint: disable=raise-missing-from
try:
result = bytearray(1)
self.i2c.readfrom_into(self.device_address, result)
except OSError:
raise ValueError("No I2C device at address: 0x%x" % self.device_address)
# pylint: enable=raise-missing-from |
|
@ladyada sure thing |
|
@ladyada Ok. This is passing |
ladyada
approved these changes
Jan 7, 2021
|
great teamwork! merged! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 12, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 5.0.0 from 4.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#99 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#100 from makermelissa/fix-precommit > Added pre-commit-config file > Added pre-commit and SPDX copyright Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_TM#1 from adeanzan/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.0.3 from 5.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#61 from mstaack/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#8 from makermelissa/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.