-
Notifications
You must be signed in to change notification settings - Fork 12
Prep for publishing as a library and adding to the Bundle #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
097cf28
Prep for publication as a library and part of the bundle
dastels 4d67bd4
Clean up earlier files
dastels eff48e2
Fix dash/underscore typo
dastels 901e591
Fix requirements
dastels 99a7b55
Start on dealing with pylint issues
dastels be3864b
Deal with pylint issues
dastels 7bd58e6
More pylint related work
dastels 558fd6c
Remove testing code
dastels 0a1018f
Remove superfluous README.md
dastels d5cd91e
Add autodoc mocks
dastels 643af23
Add mocking for adafruit_button
dastels 68fc141
Removed the todo that got forgotten and update the example
dastels e1ccd5b
Try to get the product link working
dastels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,13 @@ | ||
#pylint disable=wrong-import-position | ||
|
||
import sys | ||
sys.path.append('/Adafruit_CircuitPython_PYOA') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can remove this, its for testing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed, and Travis is green. Have another look. |
||
|
||
import board | ||
import digitalio | ||
import adafruit_sdcard | ||
import storage | ||
from adafruit_pyoa import PYOA_Graphics | ||
import board | ||
import digitalio | ||
|
||
try: | ||
sdcard = adafruit_sdcard.SDCard(board.SPI(), digitalio.DigitalInOut(board.SD_CS)) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont disable this, fix it instead!