Prep for publishing as a library and adding to the Bundle #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Jun 18, 2019
|
looks good but maybe needs some traviscare |
|
ok ping me when its passin' travis and ill do another quick 👁 |
ladyada
requested changes
Jun 18, 2019
examples/pyoa_simpletest.py
Outdated
| @@ -1,11 +1,13 @@ | |||
| #pylint disable=wrong-import-position | |||
There was a problem hiding this comment.
dont disable this, fix it instead!
examples/pyoa_simpletest.py
Outdated
| @@ -1,11 +1,13 @@ | |||
| #pylint disable=wrong-import-position | |||
|
|
|||
| import sys | |||
| sys.path.append('/Adafruit_CircuitPython_PYOA') | |||
There was a problem hiding this comment.
you can remove this, its for testing
There was a problem hiding this comment.
Fixed, and Travis is green. Have another look.
|
Sphinx is choking on displayio. I have no idea how to deal with that. |
ladyada
approved these changes
Jun 18, 2019
|
good! we can tweak more as you play w/the library :) please submit to the bundle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.