Switch to properties instead of weird functions. #6
Assignees
Labels
Comments
tannewt
added a commit
to tannewt/Adafruit_CircuitPython_PCA9685
that referenced
this issue
Jan 6, 2018
This change reduces the scope of the PCA9685 driver to simply providing PWMOut compatible objects for each channel. As a result, the motor and servo can now be used with any PWM source, not just the PCA9685. The new motor library is here: https://github.com/adafruit/Adafruit_CircuitPython_Motor Furthermore, this library is not aware of particular output configs such as the specific Adafruit Motor FeatherWing. That knowledge has been moved to a new FeatherWing library that handles all wing related initialization. Its available here: https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing Lastly, the new driver code and examples have been linted and standard library files added. Fixes adafruit#6 and fixes adafruit#7.
tannewt
added a commit
that referenced
this issue
Jan 10, 2018
This change reduces the scope of the PCA9685 driver to simply providing PWMOut compatible objects for each channel. As a result, the motor and servo can now be used with any PWM source, not just the PCA9685. The new motor library is here: https://github.com/adafruit/Adafruit_CircuitPython_Motor Furthermore, this library is not aware of particular output configs such as the specific Adafruit Motor FeatherWing. That knowledge has been moved to a new FeatherWing library that handles all wing related initialization. Its available here: https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing Lastly, the new driver code and examples have been linted and standard library files added. Fixes #6 and fixes #7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This driver has the MicroPython-ism of a setter/getter function where its a getter when values are None and setter when they are not. This is not Pythonic and confusing.
Instead, this API should be changed so that it has a number of channels that act like
pulseio.PWMOutwithfrequencyandduty_cycleas properties.frequencyof each channel would be read only because its shared amongst all channels. The outer class can have an adjustable frequency property.The text was updated successfully, but these errors were encountered: