Pixelbuf Support #2 #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed test is addressed in Adafruit_CircuitPython_Pypixelbuf #18 |
tannewt
reviewed
Apr 24, 2020
|
PixelBuf updates are merged but cannot be released until adafruit/Adafruit_CircuitPython_NeoPixel_SPI#14 is resolved and therefore block this PR from being released. |
|
Ok, PyPixelBuf 2.0.0 and NeoPixel_SPI 0.8.0 have been released. I'm going to merge this now and merge once I confirm the other two are on pypi. |
tannewt
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
Thanks for polishing this up @dunkmann00! Thanks to @rhooper for PixelBuf. 🎉
|
awesome!! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 1, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.0.0 from 5.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#83 from adafruit/tannewt-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#82 from dunkmann00/pixelbuf Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel_SPI to 0.8.0 from 0.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel_SPI#15 from dunkmann00/pypixelbuf-2.0-compat Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.0.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#11 from jimbobbennett/master > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_Pypixelbuf to 2.0.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#19 from dunkmann00/dotstar_brightness > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#18 from dunkmann00/_pixelbuf_cp > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#17 from adafruit/black-update > build.yml: add black formatting check > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#16 from kattni/update-example-name > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#12 from adafruit/pylint-update > update code of coduct: discord moderation contact section > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#11 from sommersoft/patch_coc > update pylintrc for black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for CP _pixelbuf. This aims to complete PR #74.
Works in CP versions 5 and 4 (fallback to pure python Pixelbuf impl.). In order to support the pure python version, PR #18 from the Adafruit_CircuitPython_Pypixelbuf repo is also necessary for this to work.