Skip to content

adding RP2040 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2021
Merged

adding RP2040 #75

merged 2 commits into from
Apr 15, 2021

Conversation

djecken
Copy link
Contributor

@djecken djecken commented Apr 14, 2021

adding RP2040

adding RP2040
@djecken
Copy link
Contributor Author

djecken commented Apr 14, 2021

I think this PR failed on the black checks, should I try to rerun? @makermelissa

@makermelissa
Copy link
Collaborator

If you run pre-commit on your computer it should automatically fix it.

@djecken
Copy link
Contributor Author

djecken commented Apr 15, 2021

@makermelissa @ladyada I ran the tests again this morning but is still failing. How can I do a pre-commit on my computer? Thanks

@djecken djecken requested a review from makermelissa April 15, 2021 12:45
@dhalbert
Copy link
Contributor

@makermelissa @ladyada I ran the tests again this morning but is still failing. How can I do a pre-commit on my computer? Thanks

We have a Learn page on that 🙂 :
https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

@djecken
Copy link
Contributor Author

djecken commented Apr 15, 2021

@dhalbert Thanks for the help + link. I have install the tools for running pre-commit on my mac ran it. Looks like it's failed again on the black check. Not sure how shall I proceed?
terminal-precommit

Try again - RP2040
@dhalbert
Copy link
Contributor

Did it leave the file reformatted or throw it away? If the former you can just commit again. Otherwise run black by hand and then try the commit agian.

@djecken
Copy link
Contributor Author

djecken commented Apr 15, 2021

@dhalbert Ah, yes looks like it was reformatted – I committed and waiting on checks now.

@djecken
Copy link
Contributor Author

djecken commented Apr 15, 2021

OK yay green checks ✅ this is ready to merge

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great.

@makermelissa makermelissa merged commit 0d0937d into master Apr 15, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 16, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_74HC595 to 1.3.0 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_74HC595#17 from davidleedom/patch-1
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT4x to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHT4x#4 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#8 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 2.3.0 from 2.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#75 from adafruit/rp2040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants