Adafruit_CircuitPython_74HC595: Added support for multiple shift registers #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Apr 12, 2021
I'm new to Python. Makes sense to me. Co-authored-by: Scott Shawcroft <[email protected]>
I did not know this. Co-authored-by: Scott Shawcroft <[email protected]>
I didn't really understand what this was doing in the original code, but I thought I'd just keep it. Co-authored-by: Scott Shawcroft <[email protected]>
|
Did you test the latest version? I don't always make perfect edits... |
davidleedom
commented
Apr 13, 2021
|
I think I completed everything, but being this is more first Pull Request experience I might be missing something. |
|
Yes i did.
…On Tue, Apr 13, 2021, 2:07 PM Scott Shawcroft ***@***.***> wrote:
Did you test the latest version? I don't always make perfect edits...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBGG5DE76HLE3WQSLPIWETTISB63ANCNFSM42X2MRAQ>
.
|
That's exactly what I had hoped. Thanks! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 16, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_74HC595 to 1.3.0 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_74HC595#17 from davidleedom/patch-1 > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT4x to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_SHT4x#4 from jposada202020/improving_docs > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#8 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 2.3.0 from 2.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#75 from adafruit/rp2040
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simply changed the single byte used to send to the shift register into an array. Then mapped pin values greater than 7 to the next byte. So you will see value of _byte_pos which is the element of the byte array and _byte_pin which is the bit in the _byte_pos element.