Matrix initialization improvement and max_glyphs bugfix #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also includes a bug fix for an issue when text was set initially to a certain length and then longer text was applied, it would give a max_glyphs exceeded error. It gets around by recreating a new label each time. |
makermelissa
changed the title
ladyada
approved these changes
Sep 19, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 19, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#36 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.5.0 from 1.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#19 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#18 from makermelissa/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right after I created the last PR, I thought of a good improvement that makes the code more readable.