Skip to content

Commit 7a59a76

Browse files
authored
Merge pull request #19 from makermelissa/master
Matrix initialization improvement and max_glyphs bugfix
2 parents 051180a + da9feb8 commit 7a59a76

File tree

2 files changed

+6
-23
lines changed

2 files changed

+6
-23
lines changed

adafruit_matrixportal/matrix.py

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -53,23 +53,11 @@ def __init__(self, *, width=64, height=32, bit_depth=2, alt_addr_pins=None):
5353
if alt_addr_pins is not None:
5454
addr_pins = alt_addr_pins
5555
elif hasattr(board, "MTX_ADDRA"):
56-
if height <= 16:
57-
addr_pins = [board.MTX_ADDRA, board.MTX_ADDRB, board.MTX_ADDRC]
58-
elif height <= 32:
59-
addr_pins = [
60-
board.MTX_ADDRA,
61-
board.MTX_ADDRB,
62-
board.MTX_ADDRC,
63-
board.MTX_ADDRD,
64-
]
65-
else:
66-
addr_pins = [
67-
board.MTX_ADDRA,
68-
board.MTX_ADDRB,
69-
board.MTX_ADDRC,
70-
board.MTX_ADDRD,
71-
board.MTX_ADDRE,
72-
]
56+
addr_pins = [board.MTX_ADDRA, board.MTX_ADDRB, board.MTX_ADDRC]
57+
if height > 16:
58+
addr_pins.append(board.MTX_ADDRD)
59+
if height > 32:
60+
addr_pins.append(board.MTX_ADDRE)
7361
else:
7462
addr_pins = [board.A0, board.A1, board.A2, board.A3]
7563

adafruit_matrixportal/matrixportal.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -251,19 +251,14 @@ def set_text(self, val, index=0):
251251
if not self._text:
252252
self.add_text()
253253
string = str(val)
254-
if not string:
255-
max_glyphs = 50
256-
else:
257-
max_glyphs = len(string)
258254
if self._text_maxlen[index]:
259255
string = string[: self._text_maxlen[index]]
260256
print("text index", self._text[index])
261257
index_in_splash = None
262258
if self._text[index] is not None:
263259
print("Replacing text area with :", string)
264-
self._text[index].text = string
265260
index_in_splash = self.splash.index(self._text[index])
266-
self._text[index] = Label(self._text_font, text=string, max_glyphs=max_glyphs)
261+
self._text[index] = Label(self._text_font, text=string)
267262
self._text[index].color = self._text_color[index]
268263
self._text[index].x = self._text_position[index][0]
269264
self._text[index].y = self._text_position[index][1]

0 commit comments

Comments
 (0)