update to use write_then_readinto for repeated start #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok this can now be reviewed! |
dhalbert
requested changes
Aug 19, 2018
| buf[0] = address & 0xFF | ||
| i2c.write(buf, end=1, stop=False) | ||
| i2c.readinto(buf, end=count) | ||
| i2c.write_then_readinto(bytes([address & 0xFF]), buf, |
There was a problem hiding this comment.
out_end=1 should be specified, I think.
There was a problem hiding this comment.
we dont have to because i dont use 'buf' anymore, i just create and pass in a single-byte array. oddly when i used buf, it wasnt working. i just did this instead of in-depth investigation on why i couldnt use buf for both output and input
There was a problem hiding this comment.
got it, i didn't read carefully enough
There was a problem hiding this comment.
np its confusing, ive mixed both because you write first, then read. anyways...yay!
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 20, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerp to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Fingerp#9 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 1.2.0 from 1.1.0: > fix context typo > make sure they get a recent version of busdevice with i2c write-then-read support > fix wrong reference & pylint > use single call for i2c transactions, to support linux Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#9 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.1.1 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#8 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#3 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.5 from 2.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#21 from ladyada/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested on m4 &raspi
wait till busdevice version release 2.2.5 to check travis/pr