Make compatible with pyserial, add some examples as well for computer usage #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w example for computer/linux logging
dhalbert
requested changes
Aug 19, 2018
adafruit_gps.py
Outdated
| data_type, args = sentence | ||
| data_type = data_type.upper() | ||
| if data_type == 'GPGGA': # GGA, 3d location fix | ||
| data_type = bytes(data_type.upper(), "utf-8") |
There was a problem hiding this comment.
How about using "ascii" here and below as the encoding? In CircuitPython this arg is ignored (you can say "foobar"), but in regular Python it has to be an encoding name. If pyserial is reading junk with chars >128, then it will throw an error:
>>> bytes('ab\xbb', 'ascii')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
UnicodeEncodeError: 'ascii' codec can't encode character '\xbb' in position 2: ordinal not in range(128)
>>> bytes('ab\xbb', 'utf-8')
b'ab\xc2\xbb'
>>>
adafruit_gps.py
Outdated
| self._uart.write('\r\n') | ||
| checksum ^= char | ||
| self._uart.write(b'*') | ||
| self._uart.write(bytes('{:02x}'.format(checksum).upper(), "utf-8")) |
There was a problem hiding this comment.
"utf-8" -> "ascii", per previous comment
There was a problem hiding this comment.
yah im into it. lemme do that
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 20, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerp to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Fingerp#9 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 1.2.0 from 1.1.0: > fix context typo > make sure they get a recent version of busdevice with i2c write-then-read support > fix wrong reference & pylint > use single call for i2c transactions, to support linux Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#9 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.1.1 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#8 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#3 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.5 from 2.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#21 from ladyada/master
siddacious
pushed a commit
that referenced
this pull request
Aug 31, 2019
Moving Bill's changes to my repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly turning everything into bytes instead of using strings