Update mlx90640_pygamer.py #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use simpleio.map_range, remove custom function, more comments, cleaning, rename to max_t and min_t, general improvement.
Making pylint happy...
|
This should fix #6 |
|
Looks good. Did you also test just to make sure it all still runs as expected? |
|
Yes, I have recovered my hardware and it was tested. Actually, I never tested on Adafruit Stemma/breakout but only on my older Pimoroni Breakout Garden version. This is why I would love to see someone plugging a Stemma cable between a PyGamer and the Adafruit mlx90640 breakout board. (please take a picture). I also have a PyPortal, so I may do a version with that resolution (but first I need to find/build a Stemma to Pimoroni Breakout Garden cable). |
|
OK. Those are just different ways of making the I2C connection. So shouldn't really matter in terms of testing the code. As long as you had some hardware setup for testing, should be fine. |
caternuson
approved these changes
Jan 14, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 15, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.6.0 from 2.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#47 from makermelissa/marquee > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#49 from makermelissa/matrix_scroll > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#41 from vdehors/master > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#46 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 2.0.0 from 1.0.0: > Update README.rst > Update README.rst > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#2 from adafruit/lsm6ds_refactor > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#1 from adafruit/dherrada-patch-1 > added additional rates & sensor identifier Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#7 from dglaude/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#8 from caternuson/iss2 > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#5 from dglaude/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#4 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.9.4 from 1.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#51 from makermelissa/master > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#50 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.3.3 from 1.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#24 from caternuson/iss23 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_LSM6DS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use simpleio.map_range, remove custom function, more comments, cleaning, rename to max_t and min_t, general improvement.
No new functionality, just possibly easier to understand code and removing a custom function doing map_range.