Skip to content

Should use simpleio.map_range in mlx90640_pygamer example. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dglaude opened this issue Jan 8, 2020 · 3 comments
Closed

Should use simpleio.map_range in mlx90640_pygamer example. #6

dglaude opened this issue Jan 8, 2020 · 3 comments

Comments

@dglaude
Copy link
Contributor

dglaude commented Jan 8, 2020

Talking with @CedarGroveStudios author of https://github.com/CedarGroveStudios/Thermal_Camera, I figured out that for mapping from temperature to colour palette index, I could use simpleio.map_range rather than a custom made function like I did:

This is not blocking, maybe just to put on my todo list, but anybody is welcomed to fix this before me.

The only additional feature that could make sense would be C° to F° conversion of the min and the max, that could be added. Anything else would be advance feature and not good for an example.

Any other code review is welcome.

@dglaude
Copy link
Contributor Author

dglaude commented Jan 8, 2020

This issue is fixed with Pull request #7.

@caternuson
Copy link
Contributor

caternuson commented Jan 13, 2020

OK, wanna close issue?

[EDIT] oh, wait, i see, it's not merged yet. nvm.

@caternuson
Copy link
Contributor

Now it's merged :)
Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants