Skip to content

Remove stop kwarg #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

Remove stop kwarg #23

merged 1 commit into from
Oct 15, 2020

Conversation

caternuson
Copy link
Contributor

For #18.

Quick and simple test just to make sure basics still work.

Adafruit CircuitPython 5.3.1 on 2020-07-13; Adafruit ItsyBitsy M0 Express with samd21g18
>>> import board
>>> import adafruit_mlx90393
>>> mlx = adafruit_mlx90393.MLX90393(board.I2C())
>>> mlx.magnetic
(-22.95, -32.85, -37.026)
>>>

@caternuson caternuson merged commit 57fc634 into adafruit:master Oct 15, 2020
@caternuson caternuson mentioned this pull request Oct 15, 2020
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 16, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c01bb3a)
d634410 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.0.1 from 1.4.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#23 from caternuson/iss18
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#22 from caternuson/iss20
@jepler
Copy link

jepler commented Oct 19, 2020

The code in question is reached when _transceive is called with an argument of more than 1 byte. This would happen inside @gain.setter. It would be a good idea to test that setting the gain property still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caternuson @jepler @ladyada