Skip to content

Remove use of deprecated stop=False #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jepler opened this issue Jul 26, 2020 · 4 comments
Closed

Remove use of deprecated stop=False #18

jepler opened this issue Jul 26, 2020 · 4 comments
Labels
good first issue Good for newcomers

Comments

@jepler
Copy link

jepler commented Jul 26, 2020 •
edited
Loading

Remove use of stop=False. This option is not supported in CircuitPython 6.x. https://github.com/adafruit/Adafruit_CircuitPython_MLX90393/blob/master/adafruit_mlx90393.py#L165

It looks like this will affect the setter of "gain", since it sends a payload of more than 1 byte. This property is unconditionally set in the constructor, so it may be the case that this driver cannot be used with 6.x until this is addressed.
@jepler
Copy link
Author

jepler commented Jul 26, 2020

See adafruit/Adafruit_CircuitPython_BusDevice#54

@jepler jepler added the good first issue Good for newcomers label Jul 26, 2020
@jepler jepler changed the title Remove use of deprecated stop=True. Remove use of deprecated stop=False Jul 27, 2020
@ladyada
Copy link
Member

ladyada commented Oct 15, 2020

@caternuson is this also resolved?

@caternuson
Copy link
Contributor

Hmmm...maybe that's what lint was griping about. So, no. Not resolved. Forgot about this change. I'll PR this right quick....

@caternuson caternuson mentioned this issue Oct 15, 2020
Merged
@caternuson
Copy link
Contributor

Fixed with #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ladyada @jepler @caternuson