Don't reuse exception objects #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tannewt merged 1 commit into adafruit:main from jepler:no-reuse-exception

Aug 9, 2021

Contributor

jepler commented Aug 7, 2021

Closes: #28

Contributor Author

jepler commented Aug 7, 2021

CI fails due to what #39 addresses.

Contributor

dhalbert commented Aug 7, 2021

Build failure:

adafruit_midi/mtc_quarter_frame.py:51:18: E1101: Instance of 'MtcQuarterFrame' has no '_EX_VALUEERROR_OOR' member (no-member)


          Don't re-use an exception object

3ff9f09

Closes: #28

jepler force-pushed the no-reuse-exception branch from 38f7361 to 3ff9f09 Compare

August 8, 2021 13:19

jepler requested a review from a team

August 8, 2021 13:19

dhalbert approved these changes

View reviewed changes

tannewt merged commit 0f56516 into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@f879b24)

59baf9e

Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#16 from apendley/extended_tone_demo

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.2 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#40 from jepler/no-reuse-exception
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#39 from jepler/use-generator
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#38 from EMATech/mtc

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.1.1 from 5.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#87 from DynamicDevices/ajl/fix-multiple-pingreqs

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_Ducky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet