Add MIDI Time Code Quarter Frame message support #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdoursenaud
force-pushed
the
mtc
branch
2 times, most recently
from
7abc706 to
2fb865e
Compare
|
Looks like pylint has a suggestion. I'd suggest installing pre-commit locally: https://learn.adafruit.com/improve-your-code-with-pylint/check-your-code-with-pre-commit |
|
Thanks. Here’s a version with the offending variable renamed. |
|
Thanks! The remaining problem noticed by pylint existed before your changes and we'll address it at #39. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 11, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 1.3.3 from 1.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#16 from apendley/extended_tone_demo Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#40 from jepler/no-reuse-exception > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#39 from jepler/use-generator > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#38 from EMATech/mtc Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.1.1 from 5.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#87 from DynamicDevices/ajl/fix-multiple-pingreqs Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Ducky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m working on implementing an MTC display using a MatrixPortal Starter Kit.
MTC full frame message are Global SySex and already covered by the System Exclusive message type.
Quarter Frame are their own message type and wasn’t implemented.
Here’s a tentative implementation.
Edit: Sorry for the force pushes, I cleaned up a bit of crust.