-
Notifications
You must be signed in to change notification settings - Fork 36
Add interrupt support & examples to MCP23017 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but I don't have the hardware to test so I'll leave it to you to merge or for someone else to test if need be.
As a general comment about this lib I am kinda 🤷♂️ about exposing lightly wrapped registers; on one hand it's great for those who know what they're doing, but maybe not so useful for fresh circuit pythonistas? Then I suppose that ship has sailed.
normally i wouldnt...i guess i could try to abstract em but it'd get really 'wordy' - this was to test a new hardware. |
+1 to renaming the properties to fully explain what they are. The comments are really handy so by renaming we'll remove any hint of data sheet-ism. |
but, they'd still need to be assigned and read as if they were the registers... zat ok? |
Sorry it took me a while to get back. Ya, I think it's fine that they are bitmasks. The documentation makes that clear. The fact that they map to a register under the hood isn't important though. |
added/updated! |
@tannewt ok im gonna merge this - next time i sweep thru this library ill update them to |
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#10 from dhalbert/ujson-to-json Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.3.0 from 2.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#13 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 1.2.0 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#7 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.3.0 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#24 from caternuson/iss23 Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.0.8 from 1.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#10 from dhalbert/robust-packet-reading
this is for a gpio expander bonnet, can now manipulate the IRQ control registers. also set default to be IRQ pins are open drain.