Skip to content

Fix docstrings, use duck typing #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 21, 2022
Merged

Fix docstrings, use duck typing #32

merged 8 commits into from
Jun 21, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Jun 18, 2022 •
edited
Loading

  • Fixes some docstrings that should have been updated with the latest release
  • Uses typing_extensions.Protocol for typing StreamHandler.__init__() because really it should just be able to take any stream that writes strings.

@tekktrik tekktrik requested a review from a team June 18, 2022 14:26
dhalbert
dhalbert requested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all the doc errors, especially!

@tekktrik @dhalbert
Update adafruit_logging.py
8fa1571 
Use try/except for Protocol import

Co-authored-by: Dan Halbert <[email protected]>
@tekktrik tekktrik requested a review from dhalbert June 21, 2022 14:09
dhalbert
dhalbert approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert
Copy link
Contributor

ugh, I think my proposed change has indentation issues

@dhalbert
Copy link
Contributor

@tekktrik Could you fix this in your fork? I tried a simple GitHub edit, but the formatting is still not good: black complained. You'll need to pull the latest commit.

@tekktrik
Copy link
Member Author

@dhalbert no problem, pushed the fix

@dhalbert dhalbert merged commit 4f4bd44 into adafruit:main Jun 21, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 22, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a476ee6)
c921168 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 5.0.0 from 4.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#164 from dannystaple/use-connection-errors

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.5.0 from 4.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#101 from makermelissa/multidisplay-support

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 3.0.0 from 2.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#36 from vladak/celsius

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 1.10.5 from 1.10.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#14 from tekktrik/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 4.1.1 from 4.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Logging#32 from tekktrik/doc/fix-doc-and-types
@tekktrik tekktrik deleted the doc/fix-doc-and-types branch January 23, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tekktrik @dhalbert