Skip to content

Make these connection errors distinct from other error types. #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 21, 2022

Conversation

dannystaple
Copy link
Contributor

No description provided.

@tekktrik tekktrik requested a review from a team May 11, 2022 01:31
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this! The example scripts in examples should be updated to handle the new exceptions properly. For instance, ValueError probably should not be retried any more. There is probably code in Learn Guides and other libraries that will also need to be fixed.

@makermelissa FYI

This should get a major release version bump, since it is not upward compatible.

@dannystaple
Copy link
Contributor Author

Thanks for improving this! The example scripts in examples should be updated to handle the new exceptions properly. For instance, ValueError probably should not be retried any more. There is probably code in Learn Guides and other libraries that will also need to be fixed.

@makermelissa FYI

This should get a major release version bump, since it is not upward compatible.

I've updated the examples and found a couple of other Runtime errors that should be something else.

@tekktrik tekktrik requested a review from dhalbert June 12, 2022 16:25
@tekktrik
Copy link
Member

The remaining CI failure was from the sphinx upgrade, re-ran it and it passed!

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the big rationalization of the exceptions!

@dhalbert dhalbert merged commit f3d504b into adafruit:main Jun 21, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 22, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 5.0.0 from 4.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#164 from dannystaple/use-connection-errors

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.5.0 from 4.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#101 from makermelissa/multidisplay-support

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 3.0.0 from 2.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#36 from vladak/celsius

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 1.10.5 from 1.10.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#14 from tekktrik/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 4.1.1 from 4.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Logging#32 from tekktrik/doc/fix-doc-and-types
@dannystaple dannystaple deleted the use-connection-errors branch July 20, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants