-
Notifications
You must be signed in to change notification settings - Fork 74
Make these connection errors distinct from other error types. #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this! The example scripts in examples
should be updated to handle the new exceptions properly. For instance, ValueError
probably should not be retried any more. There is probably code in Learn Guides and other libraries that will also need to be fixed.
@makermelissa FYI
This should get a major release version bump, since it is not upward compatible.
Also removed some extraneous brackets on OSerrors.
…nse from the spi device.
I've updated the examples and found a couple of other Runtime errors that should be something else. |
The remaining CI failure was from the sphinx upgrade, re-ran it and it passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the big rationalization of the exceptions!
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 5.0.0 from 4.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#164 from dannystaple/use-connection-errors Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.5.0 from 4.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#101 from makermelissa/multidisplay-support Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 3.0.0 from 2.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#36 from vladak/celsius Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 1.10.5 from 1.10.4: > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#14 from tekktrik/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 4.1.1 from 4.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#32 from tekktrik/doc/fix-doc-and-types
No description provided.