change from dps->rads for gyro to fix #9 #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
suggested changes
Apr 17, 2020
adafruit_lsm6ds.py
Outdated
| x = self._scale_gyro_data(raw_gyro_data[0]) | ||
| y = self._scale_gyro_data(raw_gyro_data[1]) | ||
| z = self._scale_gyro_data(raw_gyro_data[2]) | ||
| x = self._scale_gyro_data(raw_gyro_data[0]) * _DPS_TO_RADS |
There was a problem hiding this comment.
You could use math.radians(self._scale_gyro_data....) instead, and lose the _DPS_TO_RADS constant. math.radians() is standard in Python and I checked for its presence in CircuitPython.
There was a problem hiding this comment.
@siddacious try a x, y, z = [math.radians(self._scale_gyro_data(i)) for in raw_gyro_data]
jepler
approved these changes
Apr 20, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 24, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_AM2320 to 1.2.2 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_AM2320#16 from jerryneedell/jerryn_revert_pr_9 Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_LIS2MDL#5 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#14 from adafruit/rads_fix > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#13 from adafruit/pylint-update Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 6.1.3 from 6.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#80 from dhalbert/initial-value-none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I neglected to convert to radians/sec when I first wrote the lib, so here's a fix!
Thanks to @kevinjwalters for reporting the issue