Skip to content

Proposed docstring corrections #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Proposed docstring corrections #77

merged 1 commit into from
Feb 5, 2023

Conversation

tcfranks
Copy link
Contributor

this are changes to the base class and spi subclass docstrings. for the base class to better clarify the interrupt pin designations on the device. the subclass docstring is basically a poorly modified copy/paste of the I2C subclass and this change corrects the parameters and the python sample blocks.

@tekktrik tekktrik requested review from tekktrik and a team and removed request for tekktrik January 31, 2023 01:26
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, should be easier to understand with the pin name description changes. Thanks!

@tekktrik tekktrik merged commit 240fe51 into adafruit:main Feb 5, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants