Skip to content

Add graphviz as package on RTD #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Add graphviz as package on RTD #82

merged 1 commit into from
Feb 6, 2023

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Feb 5, 2023 •
edited
Loading

Fixes #81 using the solution provided in readthedocs/readthedocs.org#8800, which explains I wasn't able to replicate what's happening on RTD, since I have graphviz locally and sphinx builds it fine for me there.

@tekktrik tekktrik requested a review from a team February 5, 2023 23:50
jposada202020
jposada202020 approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lets see if it works, I also have Graphviz locally so never noticed this :(. Thanks again

@tekktrik tekktrik merged commit 29fe3f0 into adafruit:main Feb 6, 2023
@tekktrik
Copy link
Member Author

tekktrik commented Feb 6, 2023

Yup, that fixed it!

@jposada202020
Copy link
Contributor

Yes Thank you very much!!! i just checked 🥇

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 6, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@88e01fd)
db2a304 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.22 from 5.1.21:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#77 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.19.12 from 1.19.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#82 from tekktrik/dev/fix-docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jposada202020 jposada202020 jposada202020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sphinx Inheritance diagrams not showin in documentation
2 participants
@tekktrik @jposada202020