added typing on six different funcs: validate, generate, urlsafe_b64e… #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncode, urlsafeb64_decode, _bytes_from_decode_data, translate
FoamyGuy
requested changes
May 2, 2022
There was a problem hiding this comment.
The types all look good to me.
We'll need to add circuitpython_typing as a new dependency for that import of ReadableBuffer though.
It can get added in setup.py here:
Adafruit_CircuitPython_JWT/setup.py
Line 36 in 4204bae
install_requires=["Adafruit-Blinka", "adafruit-circuitpython-typing"],
and in requirements.txt: https://github.com/adafruit/Adafruit_CircuitPython_JWT/blob/main/requirements.txt#L5
#...
Adafruit-Blinka
adafruit-circuitpython-typing
Thanks again for all of your help on the typing PRs @ktkinsey37
Closed
6 tasks
FoamyGuy
approved these changes
May 9, 2022
There was a problem hiding this comment.
Looks good to me. Tested successfully on PyPortal.
Thanks again for all of your work on this @ktkinsey37
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 10, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.4.1 from 5.4.0: > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.2.4 from 2.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#73 from jcerise/65/missing_type_annotations > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.16.1 from 1.16.0: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#60 from matt-land/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_JWT to 1.2.6 from 1.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_JWT#11 from ktkinsey37/typing > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.7.2 from 0.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#47 from jepler/example-updates-background > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#46 from jepler/neopixel-match-core > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#45 from jepler/background-morse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ncode, urlsafeb64_decode, _bytes_from_decode_data, translate