-
Notifications
You must be signed in to change notification settings - Fork 21
Add types for #56 Missing type annotations #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
finish adafruit#56, rename types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work that went into this! Couple of simple change suggestions below.
I'll let one of the other folks check this out for type hint content.
… add copyright year
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a lot to this one, thank you so much for tackling this @matt-land
Types all look good to me and I tested all examples successfully on PyPortal 7.3.0-beta.0
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.4.1 from 5.4.0: > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.2.4 from 2.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#73 from jcerise/65/missing_type_annotations > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.16.1 from 1.16.0: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#60 from matt-land/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_JWT to 1.2.6 from 1.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_JWT#11 from ktkinsey37/typing > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.7.2 from 0.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#47 from jepler/example-updates-background > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#46 from jepler/neopixel-match-core > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#45 from jepler/background-morse
#56 This is not yet mypy passing, but it is intended for merge as is. It will likely need more work after #59. This is about as good as it gets for now. The remaining issues are due to type juggling (reassigning references from one type to another):